Scopes: Define boundaries for generated ranges in JavaScript#249
Open
szuend wants to merge 1 commit intotc39:proposal-scopesfrom
Open
Scopes: Define boundaries for generated ranges in JavaScript#249szuend wants to merge 1 commit intotc39:proposal-scopesfrom
szuend wants to merge 1 commit intotc39:proposal-scopesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
This PR takes a stab at defining some rules how generated ranges should be emitted for JavaScript. The goal is to prevent generators from emitting ranges that start in one JS lexical scope and end in another while prescribing the exact locations where
[[Start]]and[[End]]should be.I didn't want to over-complicate the rules, so instead of defining them via records and SDOs it's a simple table that lists where these "boundaries" are.
Let me know what you think of this approach!