Adding case for super access of a module namespace TDZ binding#5000
Open
Adding case for super access of a module namespace TDZ binding#5000
Conversation
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
This test case looks good. It might be worth adding one that is the same but has a set foo(_) {} setter in the base class, and then it should not throw, right?
Member
|
Just to double check that I'm understanding correctly. The ReferenceRecord for the lhs is:
In PutValue we call
I'm approving assuming that my understanding of why this test is like this is correct. |
nicolo-ribaudo
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding a case where we have an access to a TDZ biding of a namespace module using
super.prop. The case here is that we should throw aReferenceErrorinstead of aTypeError, because OrdinarySet callsReceiver.[[GetOwnProperty]]before it tries to write into the object. It's important to notice thatReceiveris a namespace object, becausesuper()will changethisbiding beforesuper.foogets executed, andOrdinarySetgets executed becausesupercreates a reference record where[[Base]] == [[FunctionObject]].[[HomeObject]].It is related with #4980.