Skip to content

Respect externally managed plugin installs and watch linked sources - #10

Draft
tcballard wants to merge 1 commit into
review/core-baseline-5ead870from
fix/plugin-lifecycle-ownership
Draft

tcballard wants to merge 1 commit into
review/core-baseline-5ead870from
fix/plugin-lifecycle-ownership

Conversation

@tcballard

@tcballard tcballard commented Sep 9, 2026 •

Copy link
Copy Markdown
Owner

Fork review draft. Intended upstream target: omacom/omarchy:quattro. Opening the upstream PR was blocked by GitHub integration permissions (403). The base branch is an exact snapshot of upstream 5ead870, so this review contains only the intended contribution.

The generic plugin updater follows installation symlinks and can advance Workbench-owned checkouts outside their reviewed revision. Recursive inotify on the plugin directory also misses edits in externally linked sources.

This skips root symlinks and installations with existing Workbench ownership receipts, validates detached update candidates before changing installed files, rechecks HEAD/cleanliness, and watches canonical linked plugin sources with events mapped back to installed IDs.

Independent of Drawer and the native Workbench panel. The receipt-path skip is a conservative interoperability proposal, not a generic upstream owner-registration API. Normal Git-directory updates are still not atomic tree swaps.

Validation: real Git fixtures cover rejected invalid candidates, successful direct updates and preservation of managed/linked checkouts; real inotify covers direct edits, external edits and link retargeting. Authentication static checks pass; desktop runtime checks remain outstanding.

Related existing proposals: omacom/omarchy#10711 (staged validation), omacom/omarchy#10705 (watch coalescing/exclusions), omacom/omarchy#10714 (system-update integration). This draft overlaps those proposals; please reconcile the staged-validation portion rather than merge duplicate implementations. It is not dependent on them as currently implemented.

Companion changes and merge order

Change Dependency
Workbench #20 Helper and QML must both support protocol 1. Drawer remains optional.
Drawer #1 Requires API 1 from the revised bundled host patch OR the core host proposal; no core merge is mandatory for local testing. Existing patch users must upgrade their patch.
Core lifecycle proposal, fork PR #10 Independent fix. Needed for reliable external live-link watching and generic-updater preservation of Workbench ownership. Overlaps upstream staged-validation/watcher proposals and should be reconciled with them.
Core host proposal, fork PR #11 Independent of Workbench and lifecycle fixes. Provides an alternative to manually applying Drawer's patch. Most host code originates with Spencer Bull.
Helper package #287 Pins Workbench source 9dce628d7e597a25f7abffa8498575f924761d97 from omacom#20; requires full supported-host tests and Arch builds. Publish before shipping the refreshed native panel.
Native Workbench #10027 Hard runtime dependency on the protocol-1 helper from omacom#287. Drawer integration is optional.

Recommended order: validate and review Workbench omacom#20, publish its reviewed helper through omacom#287, then ship the refreshed omacom#10027 panel. Drawer and its host support form a separate track. Lifecycle fixes can merge independently. None of these PRs automatically enables, installs or requires Drawer for Workbench users.

The two core PRs currently live in tcballard/omarchy because GitHub returned 403 when creating upstream PRs. Intended upstream comparisons:

Native desktop acceptance remains outstanding. Hiding is presentation only; it does not promise polling suspension or resource savings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant