Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork review draft. Intended upstream target: omacom/omarchy:quattro. Opening the upstream PR was blocked by GitHub integration permissions (403). The base branch is an exact snapshot of upstream 5ead870, so this review contains only the intended contribution.
The generic plugin updater follows installation symlinks and can advance Workbench-owned checkouts outside their reviewed revision. Recursive inotify on the plugin directory also misses edits in externally linked sources.
This skips root symlinks and installations with existing Workbench ownership receipts, validates detached update candidates before changing installed files, rechecks HEAD/cleanliness, and watches canonical linked plugin sources with events mapped back to installed IDs.
Independent of Drawer and the native Workbench panel. The receipt-path skip is a conservative interoperability proposal, not a generic upstream owner-registration API. Normal Git-directory updates are still not atomic tree swaps.
Validation: real Git fixtures cover rejected invalid candidates, successful direct updates and preservation of managed/linked checkouts; real inotify covers direct edits, external edits and link retargeting. Authentication static checks pass; desktop runtime checks remain outstanding.
Related existing proposals: omacom/omarchy#10711 (staged validation), omacom/omarchy#10705 (watch coalescing/exclusions), omacom/omarchy#10714 (system-update integration). This draft overlaps those proposals; please reconcile the staged-validation portion rather than merge duplicate implementations. It is not dependent on them as currently implemented.
Companion changes and merge order
Recommended order: validate and review Workbench omacom#20, publish its reviewed helper through omacom#287, then ship the refreshed omacom#10027 panel. Drawer and its host support form a separate track. Lifecycle fixes can merge independently. None of these PRs automatically enables, installs or requires Drawer for Workbench users.
The two core PRs currently live in tcballard/omarchy because GitHub returned 403 when creating upstream PRs. Intended upstream comparisons:
Native desktop acceptance remains outstanding. Hiding is presentation only; it does not promise polling suspension or resource savings.