[Feat][V3] Graphql rework - REQUEST FOR COMMENT#1084
Open
thomas-bassett wants to merge 11 commits intotcgdex:masterfrom
Open
[Feat][V3] Graphql rework - REQUEST FOR COMMENT#1084thomas-bassett wants to merge 11 commits intotcgdex:masterfrom
thomas-bassett wants to merge 11 commits intotcgdex:masterfrom
Conversation
Restores the main async compilation logic by uncommenting code that loads remote sources, cleans the dist folder, loads git info, and compiles endpoint files for each language. This enables the compiler to function as intended instead of being disabled by commented code.
Uncommented and activated the 'sets' query in the GraphQL schema and resolver. Updated Set.ts to properly transform sets and include card details for each set. This allows clients to fetch sets with their associated cards.
5 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
had to switch laptops due to upgrade so had to push this mid work. this may or may not work for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a full rework of the GraphQL endpoint and is likely to change. This PR is open for others to build locally and test.
With this version of then GraphQL endpoint, it completely removes the Brief/Full object structure and allows full top down and bottom up searching of every value in the API.
This is likely to have some issues and will need further work and discussion, reach out to me on discord at
@Thomas(snoogle13) with any issues for me to have a look at.this version of graphql is available under the v3 endpoint
/v3/graphqlMultilang Support
this adds multi Lang support for
cards, sets and serieswith the use of the newlocalesobject. You can still request translatable fields in the root object but can add this new object and a selection of language filters to get addition information in one languageexample query:
locales accepts all the same fields from the card object except for fields like
idas they are the sameexample return: