Add new ME variant types & Pricing IDs for ASC#1167
Conversation
🃏 295 Cards ChangedDetails: 295 modified Erika's Oddish (me02.5-001) (found using en)File: [data/Mega Evolution/Ascended Heroes/001.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/001.ts) Erika's Gloom (me02.5-002) (found using en)File: [data/Mega Evolution/Ascended Heroes/002.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/002.ts) Erika's Vileplume ex (me02.5-003) (found using en)File: [data/Mega Evolution/Ascended Heroes/003.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/003.ts) Erika's Bellsprout (me02.5-004) (found using en)File: [data/Mega Evolution/Ascended Heroes/004.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/004.ts) Erika's Weepinbell (me02.5-005) (found using en)File: [data/Mega Evolution/Ascended Heroes/005.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/005.ts) Erika's Victreebel (me02.5-006) (found using en)File: [data/Mega Evolution/Ascended Heroes/006.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/006.ts) Erika's Tangela (me02.5-007) (found using en)File: [data/Mega Evolution/Ascended Heroes/007.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/007.ts) Chikorita (me02.5-008) (found using en)File: [data/Mega Evolution/Ascended Heroes/008.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/008.ts) Bayleef (me02.5-009) (found using en)File: [data/Mega Evolution/Ascended Heroes/009.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/009.ts) Mega Meganium ex (me02.5-010) (found using en)File: [data/Mega Evolution/Ascended Heroes/010.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/010.ts) Wurmple (me02.5-011) (found using en)File: [data/Mega Evolution/Ascended Heroes/011.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/011.ts) Silcoon (me02.5-012) (found using en)File: [data/Mega Evolution/Ascended Heroes/012.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/012.ts) Beautifly (me02.5-013) (found using en)File: [data/Mega Evolution/Ascended Heroes/013.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/013.ts) Cascoon (me02.5-014) (found using en)File: [data/Mega Evolution/Ascended Heroes/014.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/014.ts) Dustox (me02.5-015) (found using en)File: [data/Mega Evolution/Ascended Heroes/015.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/015.ts) Budew (me02.5-016) (found using en)File: [data/Mega Evolution/Ascended Heroes/016.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/016.ts) Grubbin (me02.5-017) (found using en)File: [data/Mega Evolution/Ascended Heroes/017.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/017.ts) Team Rocket's Tarountula (me02.5-018) (found using en)File: [data/Mega Evolution/Ascended Heroes/018.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/018.ts) Team Rocket's Spidops (me02.5-019) (found using en)File: [data/Mega Evolution/Ascended Heroes/019.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/019.ts) Charmander (me02.5-020) (found using en)File: [data/Mega Evolution/Ascended Heroes/020.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/020.ts) Charmeleon (me02.5-021) (found using en)File: [data/Mega Evolution/Ascended Heroes/021.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/021.ts) Mega Charizard Y ex (me02.5-022) (found using en)File: [data/Mega Evolution/Ascended Heroes/022.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/022.ts) Ethan's Slugma (me02.5-023) (found using en)File: [data/Mega Evolution/Ascended Heroes/023.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/023.ts) Ethan's Magcargo (me02.5-024) (found using en)File: [data/Mega Evolution/Ascended Heroes/024.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/024.ts) Entei (me02.5-025) (found using en)File: [data/Mega Evolution/Ascended Heroes/025.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/025.ts) Ethan's Ho-Oh ex (me02.5-026) (found using en)File: [data/Mega Evolution/Ascended Heroes/026.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/026.ts) Numel (me02.5-027) (found using en)File: [data/Mega Evolution/Ascended Heroes/027.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/027.ts) Camerupt (me02.5-028) (found using en)File: [data/Mega Evolution/Ascended Heroes/028.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/028.ts) Tepig (me02.5-029) (found using en)File: [data/Mega Evolution/Ascended Heroes/029.ts](https://github.com/tcgdex/cards-database/blob/776bddbf59f5bad89d54607593df47ef75c0ee9d/data/Mega Evolution/Ascended Heroes/029.ts)
|
|
Oh, compilations errors! Sad times 😉 |
Because main doesn't yet support thirdParty inside variations :P |
|
you didnt branch off #1022, you crazy person |
|
Hi, and |
in this case the default |
Add five new foil options ('loveball', 'friendball', 'quickball', 'duskball', 'team-rocket') to the variant_detailed union in interfaces.d.ts and provide translations.
This is in preperation for the variants_detailed pricing updates
Replace singular thirdParty objects with a variants array across the Ascended Heroes card data 001-295 with CM and TCGPlayer IDs
Update interfaces.d.ts: include '30th-pokeday'
Remove duplicated "reverse" variant objects containing thirdParty pricing (cardmarket/tcgplayer) from Ascended Heroes card data files. Each file now retains the intended reverse variant with the foil property, avoiding duplicate/redundant pricing entries across the Mega Evolution/Ascended Heroes dataset.
Clean up Ascended Heroes card data by removing redundant reverse variant objects that contained thirdParty pricing (cardmarket/tcgplayer). Each file now keeps the intended reverse entry (with foil information) to avoid duplicate/inconsistent pricing entries across the data/Mega Evolution/Ascended Heroes/*.ts files.
ASC-019
14caec3 to
2bbd0f4
Compare
fixes after merge conflicts
Carkol tcgdex#119 still carried a plain `reverse` variant entry with the same cardmarket/tcgplayer IDs as its `normal` variant — a leftover from the pre-tcgdex#1167 data shape. PR tcgdex#1167 removed these redundant plain-reverse entries from the rest of the Ascended Heroes cards but missed this one. The card's real reverse variants are `reverse|duskball` and `reverse|energy`; there is no plain `reverse` print at Cardmarket ID 869730 (that's the Normal print's ID).
Shared the same cardmarket/tcgplayer IDs as the normal variant — stale leftover from the pre-tcgdex#1167 data shape. The real reverse prints are reverse|duskball and reverse|energy.
Shared the same cardmarket/tcgplayer IDs as the normal variant — stale leftover from the pre-tcgdex#1167 data shape. The real reverse prints are reverse|duskball and reverse|energy.
Shared the same cardmarket/tcgplayer IDs as the normal variant — stale leftover from the pre-tcgdex#1167 data shape. The real reverse prints are reverse|duskball and reverse|energy.
All Rare cards in this set are Rare Holo prints; upstream PR tcgdex#1167 mislabeled 22 of them as type:"normal". Only 019, 078, 127 were correctly set. Fixes the variant picker showing "Normal" for cards like Tapu Koko (067) and preserves existing collection references to the pre-PR holo variants on re-import.
All Rare cards in this set are Rare Holo prints; upstream PR tcgdex#1167 mislabeled 22 of them as type:"normal". Only 019, 078, 127 were correctly set. Fixes the variant picker showing "Normal" for cards like Tapu Koko (067) and preserves existing collection references to the pre-PR holo variants on re-import.
#1390) All Rare cards in this set are Rare Holo prints; upstream PR #1167 mislabeled 22 of them as type:"normal". Only 019, 078, 127 were correctly set. Fixes the variant picker showing "Normal" for cards like Tapu Koko (067) and preserves existing collection references to the pre-PR holo variants on re-import.




























































































































































































































































































































































Changes