fix: Handle malformed custom installation config files gracefully#850
Open
YusufErdemK wants to merge 1 commit intotchx84:masterfrom
Open
fix: Handle malformed custom installation config files gracefully#850YusufErdemK wants to merge 1 commit intotchx84:masterfrom
YusufErdemK wants to merge 1 commit intotchx84:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parseCustomInstallation() did not wrap keyFile.load_from_file() in a
try-catch block. If /etc/flatpak/installations.d/ contained a malformed,
binary, or otherwise unreadable .conf file, Flatseal would crash entirely
instead of skipping the bad file.
Also simplify the version check in portals.js for readability:
Before: this._proxy.version >= SUPPORTED_SERVICE_VERSION === false
After: this._proxy.version < SUPPORTED_SERVICE_VERSION
(functionally equivalent, but clearer)