Fix Windows NIfTI paths and release dcccpy 0.1.7 - #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nii.gzextensions instead of an 8.3.GZpathdcccpyto 0.1.7 and its default DCCCcore download to 4.3.0dcccpy.pet_motion_correct()with corrected-dynamic and motion TSV optionsContext
The initial
v4.3.0tag workflow built successfully on Linux x64/ARM and both macOS runners. Windows compiled and installed successfully, but three PET motion-correction tests failed becauseGetShortPathNameWchanged.nii.gzinputs to.GZ, preventing ITK from selectingNiftiImageIO. No GitHub Release was created.Verification
4 passed, 2 skipped13 passed, 1 skippedtwine check: passed