Repository navigation
convert CI from Travis to GitHub Actions - #25
Conversation
|
https://cloud.r-project.org/web/packages/PeakSegDP/ is available, so can you please remove the --no-examples ? |
PeakSegDP is available on CRAN, so examples can run.
Ah. I originally skipped examples because PeakSegPDPAchrom depends on PeakSegDP and I wasn't sure it was available on CRAN -- should've just checked instead of working around it. Sorry about that. I just removed --no-examples and added PeakSegDP to extra-packages. CI should pick it up now. :) |
|
I don’t think you need to add it to extra packages. it should be installed because it is listed in Suggests. |
Ahh I see. Just removed it. Thanks |
|
Actually you should not need extra-packages at all, can you please remove? |
Done, removed all extra-packages. One thing I wanted to ask about -- for PR #24, my tests depend on
I'd lean toward option 3 since it covers both CI and CRAN, but happy to go with whatever you think is cleanest. What do you think? |
|
please remove Segmentor3IsBack tests, and add fpop to Suggests. |
I've added For the Segmentor3IsBack tests, just double checking if I'm doing this right: I originally used it since the Medium test instructions mention comparing against
Or I can just remove them without a replacement if that's fine too. Let me know :) |
|
I think CI failed because Added it back along with |
|
you are right, this is documented on https://github.com/r-lib/actions/tree/v2/check-r-package |
@tdhock Thanks! Is there anything else you'd like me to change on this PR? Also quick housekeeping question before I submit my proposal -- the wiki lists Vincent as the evaluating mentor and you and Gaetano as co-mentors. Is that still the plan by the way? |
|
did you get any feedback from Vincent? It would be good to have his support, as he is author of gfpop. |
@tdhock not yet. Vincent has been CC'd on all our email exchanges but I haven't heard back from him directly. I'll reach out again in a separate email soon. That said, gfpop is still my top choice for GSoC and I'm happy to spend the extra time trying to figure things out myself. :) For the proposal, if I don't hear from Vincent between now and the submission deadline, should I still list him as evaluating mentor and you and Gaetano as co-mentors? Thanks |
|
@tdhock I just heard back from Vincent! He said he's happy to mentor if the project is accepted, and shared some really useful feedback on the proposal. I'll work on his suggestions and submit my proposal soon. :) |
Swapped
.travis.ymlfor a GitHub Actions workflow soR CMD check+ tests run on push/PR..github/workflows/R-CMD-check.yaml(ubuntu-latest, R release).travis.yml--no-examplesto skipPeakSegPDPAchrom(needsPeakSegDPwhich isn't available)Segmentor3IsBackandfpopinstalled viaextra-packagespasses locally:
R CMD check --no-manual --no-examples→ Status: OK