Skip to content

Log the match details at the start of the log file #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
npetrangelo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Log the match details at the start of the log file #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf55012
Log the match details at the start of the log file
npetrangelo Apr 5, 2018
05cae40
Added try-catch block
npetrangelo Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/org/usfirst/frc/team467/robot/Logging.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
import org.usfirst.frc.team467.robot.Autonomous.Action;
import org.usfirst.frc.team467.robot.Autonomous.ActionGroup;
import org.usfirst.frc.team467.robot.vision.VisionIntegration;

import edu.wpi.first.wpilibj.DriverStation;

import org.usfirst.frc.team467.robot.Autonomous.MatchConfiguration;
import org.usfirst.frc.team467.robot.simulator.DriveSimulator;
import org.usfirst.frc.team467.robot.simulator.draw.RobotShape;
Expand Down Expand Up @@ -56,8 +59,17 @@ private static void setupDefaultLogging() {
System.out.println("Failed to create log file appender: " + e.getMessage());
}

try {
DriverStation station = DriverStation.getInstance();
String event = station.getEventName();
String type = station.getMatchType().name();
String match = Integer.toString(station.getMatchNumber());

@AndrewItIs AndrewItIs Apr 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the log match data is for but if it's for what I think it is, I think that there should be an if statement to check if any of the strings are null, if they are they should be reassigned as "No event data found" or "No match data found" instead of catching the null pointer by the string.join. I think this will be able to eliminate the need for a try-catch and it will be able to tell what specifically went wrong, further it will tell us other match data instead of just giving a blanket "no match data".

Logger.getRootLogger().info(String.join(" ", event, type, match));

@AndrewItIs AndrewItIs Apr 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the delimiter should probably be something other than just a space to prevent confusion when looking through quickly, but it probably won't matter too much in this case.

} catch (NullPointerException e) {
Logger.getRootLogger().info("No match data");
}

// Set the default log level to INFO.
// Set the default log level to ERROR.
Logger.getRootLogger().setLevel(Level.ERROR); // changing log level
}
}