Cross-platform restart script, pnpm 10 overrides migration, passthrough-reason dashboard detail#125
Open
SiNaPsEr0x wants to merge 5 commits into
Open
Cross-platform restart script, pnpm 10 overrides migration, passthrough-reason dashboard detail#125SiNaPsEr0x wants to merge 5 commits into
SiNaPsEr0x wants to merge 5 commits into
Conversation
- transform: whitelist XML tags with static/dynamic split - tracker/library: post-render profitability verification - dashboard: surface passthrough reasons (fragments/types) - scripts: replace restart.sh with cross-platform restart.mjs (+ .gitattributes) - build: migrate to pnpm workspace overrides - chore: ignore local log_chat.html export
The file no longer exists in the repo and never appears in its history. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A26PMoMZzofxidLchQNN6o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent fixes/improvements bundled together:
1. Cross-platform
restartscriptscripts/restart.sh(Bash) withscripts/restart.mjs(Node), sopnpm restartworks on Windows without requiring git-bash/WSL..gitattributesto force*.sh text eol=lf, preventing CRLF corruption of any remaining shell scripts on Windows checkouts.tests/restart.test.sh(Bash-only test for the removed script) and the correspondingtest:restartnpm script; the newrestart.mjsbehavior is exercised manually since it's a thin process-management wrapper.2. pnpm 10 overrides migration
pnpm.overridesblock frompackage.jsontopnpm-workspace.yaml, which is where pnpm 10 actually reads overrides from (thepackage.jsonlocation is silently ignored on pnpm 10, so thews/vite/undici/esbuildsecurity pins were not being applied).allowScriptsblock foresbuild,sharp, andworkerdsopnpm installdoesn't prompt/block on their postinstall scripts.3. Passthrough-reason detail (transform / tracker / dashboard / shell log)
render_not_profitablepassthrough reason (distinct from the existingnot_profitable) and akept_sharpcounter, threaded throughTransformInfo→TrackEvent→ dashboardRecentRow.PASSTHROUGH_REASON_LABELSandformatPassthroughReasons()insrc/core/transform.tsas the single source of truth for reason labels, consumed by both the shell logger (src/node.ts, newpassthrough[...]log tag) and the dashboard (src/dashboard/fragments.ts) so the CLI log and the web UI never drift out of sync.below_threshold/not_profitable/render_not_profitableinto a singletextbadge with a tooltip breakdown (previously showed a confusing "image below threshold" label on rows that were actually sent as text), and keepskept_sharpas its own visible badge since that's an image that intentionally skipped compression, not text.4. Misc
.gitignore: exclude locallog_chat.htmlexport artifact.Testing
pnpm typecheck/ existing vitest suite (transform/tracker coverage unaffected by the additive fields).pnpm restarton Windows (git-bash) and confirmed the previous$'\r': command not foundfailure is gone.pnpm installno longer needs interactive approval for esbuild/sharp/workerd postinstall scripts, and that the ws/vite/undici/esbuild overrides are actually applied (pnpm why <pkg>).Happy to split into separate PRs if preferred — flagging here in case reviewers want the pnpm-overrides fix isolated since it's the most "drop-in" of the three.