fix: enable background playback for video trimmer. Required for Android#1
Open
adithya1012 wants to merge 1 commit into
Open
fix: enable background playback for video trimmer. Required for Android#1adithya1012 wants to merge 1 commit into
adithya1012 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Video Stuttering on Android by Enabling Background Playback
Summary
This PR fixes a video stuttering issue on Android by enabling background playback for the
Videocomponent used inVideoTrimmer.Problem
On Android, the video playback was stuttering while playing because the app state was rapidly switching between
activeandbackgroundduring playback.This caused the video to pause and resume repeatedly, resulting in an unstable trimming experience.
Solution
To prevent playback interruptions,
playInBackground={true}has been added to theVideocomponent.This ensures the video continues playing continuously even when the app momentarily transitions to the background.
Changes
playInBackground={true}to theVideocomponent insrc/components/VideoTrimmer.tsxPlatform Behavior
Testing
Impact