fix: prevent stop recording for transfers [CHI-3598]#3857
Open
fix: prevent stop recording for transfers [CHI-3598]#3857
Conversation
stephenhand
approved these changes
Feb 2, 2026
Collaborator
stephenhand
left a comment
There was a problem hiding this comment.
LGTM - one question, you said you think it will fix it but can't be sure - can we not deterministically test this? If it's any cold transfer causing the issue we should be able to confirm the fix with a 'broken before, fixed after' QA test?
| ); | ||
|
|
||
| console.info( | ||
| `No participants identified as Aselo agents still in conference ${conferenceSid}, candidate to stop recordings`, |
Collaborator
There was a problem hiding this comment.
Suggested change
| `No participants identified as Aselo agents still in conference ${conferenceSid}, candidate to stop recordings`, | |
| `No participants identified as Aselo agents still in conference ${conferenceSid}, will stop recordings if this is not a transfer`, |
Collaborator
There was a problem hiding this comment.
Also possibly more of a debug log?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
Checklist
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P