Skip to content

fix: prevent stop recording for transfers [CHI-3598]#3857

Open
gpaoloni wants to merge 2 commits intomasterfrom
gian_CHI-3598
Open

fix: prevent stop recording for transfers [CHI-3598]#3857
gpaoloni wants to merge 2 commits intomasterfrom
gian_CHI-3598

Conversation

@gpaoloni
Copy link
Collaborator

@gpaoloni gpaoloni commented Jan 29, 2026

Description

This PR

  • Prevents "stop recording" upon participant leave event IF the participant left the conference because of a transfer.
    • Should fix the bug linked below - "should" because we are not certain of the root cause, but this seems like the most logical explanation.
  • Small refactor in the code: split function used in loop for readability, prefer early return over nested if statements.

Checklist

  • CHI-3598
  • New tests added
  • Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@gpaoloni gpaoloni changed the title Gian chi 3598 fix: prevent stop recording for transfers [CHI-3598] Jan 29, 2026
@gpaoloni gpaoloni marked this pull request as ready for review January 29, 2026 21:08
@gpaoloni gpaoloni requested a review from stephenhand January 29, 2026 21:08
Copy link
Collaborator

@stephenhand stephenhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one question, you said you think it will fix it but can't be sure - can we not deterministically test this? If it's any cold transfer causing the issue we should be able to confirm the fix with a 'broken before, fixed after' QA test?

);

console.info(
`No participants identified as Aselo agents still in conference ${conferenceSid}, candidate to stop recordings`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`No participants identified as Aselo agents still in conference ${conferenceSid}, candidate to stop recordings`,
`No participants identified as Aselo agents still in conference ${conferenceSid}, will stop recordings if this is not a transfer`,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also possibly more of a debug log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants