Repository navigation
Conversation
…hFromCsv Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: febb7c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
Preview deploymenthttps://pr-1010-layerchart.techniq.workers.dev Built from febb7c4. |
Contributor
Bundle Size AnalysisUse-Case ScenariosGraph / network (1 changed)
Components (1 changed)
Worst case (1 changed)
Understanding this report
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes three dependencies that each covered one small piece of code, dropping 12 packages (~2.9 MB) from a layerchart install (production dependency tree goes from 71 to 59 packages).
d3-dsvsankeyGraphFromCsv()d3-dsv,iconv-lite,safer-buffer,rw(command-line-only deps)d3-geo-polygongeoGrayFullerRaw(public domain, ~60 lines), used only byGeoBin's sphere gridd3-geo-polygon,d3-geo-projection,commanderd3-sankeyd3-sankeyplus older duplicated3-array@2,internmap@1,d3-shape@1,d3-path@1Bundles barely change, since bundlers already dropped most of this: the Sankey layout is ~330 B gzipped smaller (no fluent API, shares the app's
d3-arrayv3).Behavior
sankeyGraphFromCsv()no longer handles quoted fields ("A, Inc",B,1). Otherwise its output is identical, checked against d3-dsv on varied inputs (line endings, blank lines, padded values, extra columns).nodeSort/linkSortmode (unset,null, comparator), with d3-sankey running on its own d3-array v2. The circular-link and missing-node errors match too.Types
SankeyNode,SankeyLinkandSankeyGraphare now layerchart's own types, exported fromlayerchart, and structurally compatible with@types/d3-sankey. They addlayer, which d3-sankey always sets but@types/d3-sankeyomitted, so two docs examples drop a now-unneeded@ts-expect-error.Sankeychildrensnippet'slinkswas typed as nodes; it's nowSankeyLink[].@ts-expect-errors are gone fromSankey.svelteand one fromGeoBin.sphere.ts.Testing
sankey.test.ts(CSV parsing) andsankeyLayout.test.ts(layout pinned to d3-sankey's output for each alignment,fixedValue, error cases).pnpm checkin the package: 0 errors. Docssvelte-checkreports the same errors as before this branch, none of them new.🤖 Generated with Claude Code