Conversation
Remux was hardcoded to skip -bsf:a aac_adtstoasc to avoid breaking
AC3/EAC3/MP3 audio, but that meant AAC audio from MPEG-TS sources
always failed to remux ("Malformed AAC bitstream detected"). Probe
results (info.audio) were already available at every call site but
never passed through to the remux endpoint.
Thread audioCodec through all four remux call sites (auto-remux and
force-remux paths in both WatchPage.js and VideoPlayer.js, adding a
probe call to the two force-remux paths that previously had none) and
apply the filter server-side only when audioCodec is aac. Also removes
a harmless duplicate -user_agent flag in remux.js.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SJvfjjDJQW4zPWvjHu8JGn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remux was hardcoded to skip -bsf:a aac_adtstoasc to avoid breaking AC3/EAC3/MP3 audio, but that meant AAC audio from MPEG-TS sources always failed to remux ("Malformed AAC bitstream detected"). Probe results (info.audio) were already available at every call site but never passed through to the remux endpoint.
Thread audioCodec through all four remux call sites (auto-remux and force-remux paths in both WatchPage.js and VideoPlayer.js, adding a probe call to the two force-remux paths that previously had none) and apply the filter server-side only when audioCodec is aac. Also removes a harmless duplicate -user_agent flag in remux.js.
Closes #152