Conversation
Add ability to sort links in a list by name (A-Z, Z-A) or date (created/modified, newest/oldest). The sort preference is persisted per list. - Add LinkSortOrder enum with 6 sort options - Add linkSortOrder property to LinkListModel - Add sort menu to link list detail toolbar - Add unit tests for sorting behavior - Add localization strings for sort options Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sentry Build Distribution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to sort links in a list by name or date, with the preference persisted per list.
Users can now sort links by:
The sort order is stored on each
LinkListModel, allowing different lists to have different sort preferences. The default sort order is Name (A-Z), which also makes screenshot tests deterministic.Implementation:
LinkSortOrderenum in FlinkyCore with sorting logic usinglocalizedCaseInsensitiveComparefor nameslinkSortOrderproperty onLinkListModel(optional, defaults to.nameAscending)Note: The test file
LinkSortOrderTests.swiftneeds to be added to the FlinkyCoreTests target in Xcode.