Conversation
c7ee235 to
7e6d3cf
Compare
Collaborator
|
commit 7e6d3cf contains the actual fix. Everything else is test code or changes to make the code unit testable: commit 7e6d3cf98587fa09f45cff8f4861afaa270d1a04 (HEAD -> fix/257, upstream/fix/257)
Author: Zach Carrington <zdc@illinois.edu>
Date: Thu Nov 20 16:02:04 2025 -0600
Fix aws-login unexpected keyword argument error
Closes #257
diff --git a/src/awscli_login/credentials.py b/src/awscli_login/credentials.py
index 39ef7cd..420ce8a 100644
--- a/src/awscli_login/credentials.py
+++ b/src/awscli_login/credentials.py
@@ -11,7 +11,7 @@ from datetime import datetime
from botocore.session import Session
-from .__main__ import main as login, logout
+from .__main__ import main as aws_login, login, logout
from ._version import version
from .account_names import edit_account_names
from .config import Profile, error_handler
@@ -121,7 +121,7 @@ def main():
if ns.debug_info:
debug_info()
return
- return login(ns, session)
+ return aws_login(ns, session)
elif args.logout:
return logout(Namespace(**json.load(args.logout)), session)
elif args.alias:
|
Collaborator
|
I am able to reproduce the error without the fix above: After applying the fix the error goes away: |
edthedev
approved these changes
Dec 12, 2025
Contributor
mpitcel
approved these changes
Dec 12, 2025
ddriddle
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257