Skip to content

Fix integration tests#262

Merged
ddriddle merged 2 commits intotechservicesillinois:masterfrom
kwessel:feature/openldap-container
Dec 17, 2025
Merged

Fix integration tests#262
ddriddle merged 2 commits intotechservicesillinois:masterfrom
kwessel:feature/openldap-container

Conversation

@kwessel
Copy link
Collaborator

@kwessel kwessel commented Dec 5, 2025

  • Add LDAP Dockerfile to replace missing DockerHub image.
  • Fix failing V2 integration test.

Closes #261

@kwessel kwessel requested review from ddriddle and edthedev December 5, 2025 22:47
@kwessel kwessel self-assigned this Dec 5, 2025
@kwessel kwessel added bug Something isn't working enabler Completing this effort enables future work. blocker Other effort is blocked by this need ensemble A good issue to work on in ensemble labels Dec 5, 2025
@edthedev
Copy link
Contributor

I have moved this into 'Engagements' in our board, as we plan to get together with @kwessel to collaborate on this, likely next week.

@edthedev
Copy link
Contributor

I think I parsed the key message out of yesterday's remaining test failure:

# -- no output line contains substring --
# substring : aws: error: argument command: Invalid choice
# output (14 lines):
#   No AWS region has been configured. The AWS region is the geographic location of your AWS resources.

Basically, we are expecting our own custom failure message, but we don't get there because AWS wants more configuration.

Probably a behavior change in AWS CLI.

@ddriddle ddriddle force-pushed the feature/openldap-container branch 4 times, most recently from 98e72d2 to dcb3a02 Compare December 16, 2025 22:11
@ddriddle ddriddle force-pushed the feature/openldap-container branch from dcb3a02 to 0c83db2 Compare December 16, 2025 22:22
@ddriddle ddriddle changed the title LDIF file to load into OpenLDAP server for test phase Fix integration tests Dec 16, 2025
@ddriddle ddriddle marked this pull request as ready for review December 16, 2025 22:25
@ddriddle ddriddle merged commit 1a26a3c into techservicesillinois:master Dec 17, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker Other effort is blocked by this need bug Something isn't working enabler Completing this effort enables future work. ensemble A good issue to work on in ensemble

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration tests are failing due to missing Docker Hub OpenLDAP image

4 participants