Conversation
The default instance type was t2.nano, which is an obsolete type. Furthermore, using defaults for this sort of argument is of dubious usefulness since the end user should be determining resource needs.
Don't force a rebuild on an AMI change. That being said, EC2 instances ought to be periodically relaunched to update to the latest images.
JonRoma
requested review from
cmaturi,
dimpsey,
eccoleman,
ecohmanuiuc,
jgrier-iamu and
kwessel
JonRoma
added
bug
kwessel
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and more.