abort metrics parsing on failed docker exec calls - #23
Open
kujenga wants to merge 1 commit into
Open
Conversation
Owner
|
I'm kinda stewing on this, I'm not sure that I want to make larger changes to the "docker" style, as it's being replaced with the RPC calls soon. |
Author
|
Fair enough, the RPC layer will definitely be nice when it's ready. I was motivated to put this changeset together because I kept seeing metrics streams for |
Owner
|
Can you put in a new PR for a very narrow regex on the validator name? I think it happens intermittently. I'm on vacation for this week, I can approve and release a narrow PR though. |
kujenga
force-pushed
the
at/error-handling
branch
from
July 8, 2021 01:51
3851121 to
cf0902d
Compare
This commit eliminates cases where the commands might exit with a non-zero code and have the follow-on logic parse stack traces or other errors that could result in invalid metrics being published. This should close tedder#14
kujenga
force-pushed
the
at/error-handling
branch
from
July 8, 2021 02:33
cf0902d to
e116453
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit eliminates cases where the commands might exit with
a non-zero code and have the follow-on logic parse stack traces
or other errors that could result in invalid metrics being published.
This should close #14