Fix/security and code quality#3
Open
HugoMSFT wants to merge 3 commits into
Open
Conversation
added 3 commits
March 22, 2026 22:04
- Path traversal: validate filename and realpath containment in CSV download - Thread safety: add threading.Lock around global mutable state - Connection leaks: add finally blocks to all DB methods in fabric_sql_writer and state_manager - Session leaks: add close() to all collector classes; call after collect() - Code injection: validate table_name and write_mode in PySpark payload generation - JWT handling: validate token structure before decoding payload - Input validation: add keyword count/length limits and Flask MAX_CONTENT_LENGTH - Replace ast.literal_eval with json.loads for CSV keyword parsing - Replace stderr debug prints with proper logger calls in fabric_writer - Remove unused xml.etree.ElementTree import and redundant inline json imports - Add exc_info=True to exception handlers missing stack traces - Remove overly-aggressive regex that stripped legitimate text in utils.py - Warn when FLASK_SECRET_KEY is not set instead of silently using default
- Fix Failed to fetch: add threaded=True to Flask, replace SSE with polling, inline collect handler to avoid browser connection limits - Fix KeyError in detect_audience() for DBA/Data Engineer categories - Remove Reddit collector (policy compliance) - Remove Azure Updates collector - Add new no-auth collectors: DEV.to, Hacker News, MSSQLTips, SQLServerCentral, dbt Community, Microsoft Feedback Portal - Fix Stack Overflow: search individual keywords, remove restrictive tag filter, add dedup by question_id - Fix MSSQLTips RSS URL - Tighten keywords.json to data-virtualization-specific terms only - Fix insights page: show local dashboard when Power BI is not configured - Disable GitHub/ADO sources by default (require credentials) - Add cache-busting to JS includes - Change default port to 5001 (avoid macOS AirPlay conflict)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.