chore: use official artifacthub stepactions for git-clone#2758
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Tekton pipeline configurations to use the hub resolver instead of the http resolver for the git-clone stepaction, referencing version 0.2 from the tektoncd catalog. It also removes a local git-clone stepaction definition file and improves error handling in bootstrap.go by wrapping the error with %w instead of formatting it as a string with %s. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
=======================================
Coverage 59.73% 59.73%
=======================================
Files 210 210
Lines 21112 21112
=======================================
Hits 12611 12611
Misses 7706 7706
Partials 795 795 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chmouel
force-pushed
the
use-hub-resolver-for-git-clone
branch
3 times, most recently
from
308be5a to
f99e80e
Compare
theakshaypant
left a comment
theakshaypant
left a comment
There was a problem hiding this comment.
Changes LGTM.
The title, however, seems inaccurate since we are not using hub resolver.
Maybe something like chore(tekton): point git-clone stepaction at upstream catalog
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
@chmouel any reason not to use https://artifacthub.io/packages/tekton-stepaction/git-clone-stepaction/git-clone instead ?
|
ah yeah i did use the hub resolver at first but had some issues using it on dogfooding, so used the http URL instead |
chmouel
changed the title
|
Well I meant https://github.com/tektoncd-catalog/git-clone/blob/v1.6.0/stepaction/git-clone/git-clone.yaml instead of the one in the tektoncd/catalog |
chmouel
force-pushed
the
use-hub-resolver-for-git-clone
branch
from
f99e80e to
b27e8f7
Compare
|
ah yeah you right i got mixed up, this should be addresse in latest push, |
chmouel
changed the title
chmouel
changed the title
Preserves the error chain for errors.Is/errors.As callers. Co-Authored-By: Claude <noreply@anthropic.com>
Replaced the local HTTP-based git-clone stepaction with the official Tekton Hub resolver across Tekton workflows. Removed the redundant local stepaction definition file to keep configuration centralized. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
force-pushed
the
use-hub-resolver-for-git-clone
branch
from
b27e8f7 to
590fa5c
Compare
|
/retest |
|
I think there is an issue with the dogfooding cluster or aws as this is really slow today |
|
/test linters |
ah |
4 participants
📝 Description of the Change
Replace the vendored
git-cloneStepAction (.tekton/stepactions/git-clone.yaml) with a reference to the upstreamtektoncdcatalog via thehubresolver. The local copy was a verbatim duplicate of catalog version 0.2 — no reason to carry it.Also fixes error wrapping in
DetectPacInstallation(%s+.Error()→%w) to preserve the error chain forerrors.Is/errors.As.🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix any issues. For an efficient workflow, I have considered installing pre-commit and runningpre-commit installto automate these checks.