fix: honour overwrite in write_pandas - #377
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
write_pandas accepted an overwrite parameter but never used it, so data was always appended. With overwrite=True the table is now truncated first, or dropped and recreated when auto_create_table is also set, matching the snowflake-connector-python behaviour. Closes tekumara#290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290
write_pandasaccepted anoverwriteparameter but never used it, so rows were always appended. Withoverwrite=Truethe table is now truncated first, or dropped and recreated whenauto_create_tableis also set, matching snowflake-connector-python.This change was prepared with AI assistance; the regression tests were run locally and fail without the fix.