Skip to content

fix(push-container-image): upload tag manifest.json - #223

Draft
ACoolmanTelicent wants to merge 4 commits into
mainfrom
TELDEVOPS-1098/tag-manifest
Draft

ACoolmanTelicent wants to merge 4 commits into
mainfrom
TELDEVOPS-1098/tag-manifest

Conversation

@ACoolmanTelicent

@ACoolmanTelicent ACoolmanTelicent commented May 19, 2026

Copy link
Copy Markdown
Contributor

Ticket: https://telicent.atlassian.net/browse/TELDEVOPS-1098
📣 (partially) AI-generated: Requires line-by-line review

Goal

Let devs run gh run download to published tag. Unblocks auto-helm chart PRs from local.

Work Completed

flowchart TD
    subgraph fe["fe-mono-closed"]
        APP(["app-publish.yml"]):::ci -->|uses| PCI

        subgraph PCI["push-container-image (this PR)"]
            B([build-images]):::ci --> META["steps.meta.outputs.json"]:::ci
            META --> M([Write tag-manifest.json]):::new
            M --> U([Upload artifact]):::new
        end

        APP --> HELM([push-helm-chart]):::ci
        HELM --> DIS([repository_dispatch]):::ci
    end

    subgraph k8s["k8s-manifests"]
        DIS --> VER([update-app-version.yaml]):::ci
    end

    U -.->|"manual: gh run download"| SH(["update-helm-chart-image.sh --from="]):::local

    style fe fill:none,stroke:#333,stroke-dasharray:4 4,color:#aaa
    style PCI fill:none,stroke:#444,stroke-dasharray:4 4,color:#aaa
    style k8s fill:none,stroke:#333,stroke-dasharray:4 4,color:#aaa
    classDef ci fill:#21262d,color:#e6edf3,stroke:#30363d,stroke-width:1px
    classDef local fill:#555,color:#fff,stroke:#444
    classDef new fill:#21262d,color:#e6edf3,stroke:#00ff88,stroke-width:2px

    subgraph legend["Legend"]
        LN([new in this PR]):::new
    end
    style legend fill:none,stroke:#333,stroke-dasharray:4 4,color:#aaa
Loading

Two steps added to push-container-image/action.yml after build-images:

  1. Write steps.meta.outputs.json/tmp/tag-manifest.json
  2. Upload as artifact tag-manifest-<prefix><app><suffix>

Guard: dry-run == false + actor != dependabot. No change for existing consumers.

Proof ✅

Post-merge: update app-publish.yml ref from @TELDEVOPS-1098/tag-manifest to @main.

Related

https://github.com/Telicent-io/k8s-manifests/pull/2765

Engineering Notes

JSON shape matches what update-helm-chart-image.sh --from= already consumes.

@ACoolmanTelicent
ACoolmanTelicent marked this pull request as ready for review May 19, 2026 19:09
@ACoolmanTelicent ACoolmanTelicent self-assigned this May 19, 2026
uses: actions/upload-artifact@v7
with:
name: tag-manifest-${{ inputs.app-name-prefix }}${{ inputs.app-name }}${{ inputs.image-suffix }}
path: /tmp/tag-manifest.json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ${{ runner.temp}}/tag-manifest.json

Fulfils the same function but it's guaranteed writeable and emptied on each run

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ACoolmanTelicent
ACoolmanTelicent marked this pull request as draft June 2, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants