fix(push-container-image): upload tag manifest.json - #223
Draft
ACoolmanTelicent wants to merge 4 commits into
Draft
ACoolmanTelicent wants to merge 4 commits into
ACoolmanTelicent wants to merge 4 commits into
Conversation
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: tag-manifest-${{ inputs.app-name-prefix }}${{ inputs.app-name }}${{ inputs.image-suffix }} | ||
| path: /tmp/tag-manifest.json |
Contributor
There was a problem hiding this comment.
use ${{ runner.temp}}/tag-manifest.json
Fulfils the same function but it's guaranteed writeable and emptied on each run
robf-telicent
requested changes
Jun 2, 2026
robf-telicent
approved these changes
Jun 2, 2026
ACoolmanTelicent
marked this pull request as draft
June 2, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://telicent.atlassian.net/browse/TELDEVOPS-1098
📣 (partially) AI-generated: Requires line-by-line review
Goal
Let devs run
gh run downloadto published tag. Unblocks auto-helm chart PRs from local.Work Completed
flowchart TD subgraph fe["fe-mono-closed"] APP(["app-publish.yml"]):::ci -->|uses| PCI subgraph PCI["push-container-image (this PR)"] B([build-images]):::ci --> META["steps.meta.outputs.json"]:::ci META --> M([Write tag-manifest.json]):::new M --> U([Upload artifact]):::new end APP --> HELM([push-helm-chart]):::ci HELM --> DIS([repository_dispatch]):::ci end subgraph k8s["k8s-manifests"] DIS --> VER([update-app-version.yaml]):::ci end U -.->|"manual: gh run download"| SH(["update-helm-chart-image.sh --from="]):::local style fe fill:none,stroke:#333,stroke-dasharray:4 4,color:#aaa style PCI fill:none,stroke:#444,stroke-dasharray:4 4,color:#aaa style k8s fill:none,stroke:#333,stroke-dasharray:4 4,color:#aaa classDef ci fill:#21262d,color:#e6edf3,stroke:#30363d,stroke-width:1px classDef local fill:#555,color:#fff,stroke:#444 classDef new fill:#21262d,color:#e6edf3,stroke:#00ff88,stroke-width:2px subgraph legend["Legend"] LN([new in this PR]):::new end style legend fill:none,stroke:#333,stroke-dasharray:4 4,color:#aaaTwo steps added to
push-container-image/action.ymlafterbuild-images:steps.meta.outputs.json→/tmp/tag-manifest.jsontag-manifest-<prefix><app><suffix>Guard:
dry-run == false+ actor != dependabot. No change for existing consumers.Proof ✅
Post-merge: update
app-publish.ymlref from@TELDEVOPS-1098/tag-manifestto@main.Related
https://github.com/Telicent-io/k8s-manifests/pull/2765
Engineering Notes
JSON shape matches what
update-helm-chart-image.sh --from=already consumes.