fix: add simple knowledge dataset config - #455
tatelicent wants to merge 7 commits into
Conversation
rvesse
left a comment
rvesse
left a comment
There was a problem hiding this comment.
Some incorrect comments about update endpoints need addressing
There's no Istio related changes to the Helm Chart in this PR so any access to the new endpoints would currently be rejected by Istio before ever reaching SC-Graph
Outside of this PR you also need to consider that AuthZ policies are automatically injected based upon the name of the dataset. So for an end user to actually use these endpoints they'd have to have new api.simple-knowledge.read permissions (and api.simple-knowledge.write if you wish them to have update privileges) which don't currently exist in our Auth Server. Thus these cannot currently be assigned to any user and no user can access any of the new endpoints.
…d, also removed update and sparql endpoints for simple knowledge.
rvesse
left a comment
rvesse
left a comment
There was a problem hiding this comment.
Inconsistent fencing of the new configuration behind the values.yaml flag
3 participants
No description provided.