Add pnpm to api -> api-go sync Github Actions runner#276
Closed
long-nt-tran wants to merge 1 commit into
Closed
Conversation
|
Semgrep found 1 No explicit |
Contributor
Author
|
closing this one, can't manually kick off a GHA from a fork. Will use a branch off upstream for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
pnpmwas recently added to the Makefile target fornexus-rpc-gen-install, which runs as part of the GHA that syncs protos fromapitoapi-govia this command:make install update-proto testWe also need to add
pnpmto here, otherwise the GHA runner will fail, i.e., https://github.com/temporalio/api-go/actions/runs/26116994851/job/76808739969:Why?
So GHA runner works.
How did you test it?
Please advise