Skip to content

Add pnpm to api -> api-go sync Github Actions runner#276

Closed
long-nt-tran wants to merge 1 commit into
temporalio:masterfrom
long-nt-tran:add-pnpm-gha-runner
Closed

Add pnpm to api -> api-go sync Github Actions runner#276
long-nt-tran wants to merge 1 commit into
temporalio:masterfrom
long-nt-tran:add-pnpm-gha-runner

Conversation

@long-nt-tran
Copy link
Copy Markdown
Contributor

What changed?

pnpm was recently added to the Makefile target for nexus-rpc-gen-install, which runs as part of the GHA that syncs protos from api to api-go via this command: make install update-proto test

We also need to add pnpm to here, otherwise the GHA runner will fail, i.e., https://github.com/temporalio/api-go/actions/runs/26116994851/job/76808739969:

Run make install update-proto test
  make install update-proto test
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Install nexus-rpc-gen from main...
Cloning into '/home/runner/.cache/nexus-rpc-gen'...
/bin/sh: 1: pnpm: not found
make: *** [Makefile:133: nexus-rpc-gen-install] Error 127

Why?

So GHA runner works.

How did you test it?

Please advise

@long-nt-tran long-nt-tran requested review from a team as code owners May 19, 2026 19:26
@semgrep-managed-scans
Copy link
Copy Markdown

Semgrep found 1 missing-explicit-permissions finding:

No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

@long-nt-tran
Copy link
Copy Markdown
Contributor Author

closing this one, can't manually kick off a GHA from a fork. Will use a branch off upstream for this

@long-nt-tran long-nt-tran deleted the add-pnpm-gha-runner branch May 19, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant