Add Stats to DescribeWorkerDeploymentVersion#603
Merged
Conversation
stephanos
changed the title
stephanos
force-pushed
the
worker-deployment-stats
branch
6 times, most recently
from
f2d2dde to
412818a
Compare
cretz
reviewed
Jun 24, 2025
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
LGTM from a syntax POV, but will defer to other SDK team members more familiar w/ versioning. I admit I don't understand VersionTaskQueueInfo vs VersionTaskQueue and such.
Contributor
Author
|
FWIW, |
Contributor
Author
|
Update: I just added |
stephanos
force-pushed
the
worker-deployment-stats
branch
2 times, most recently
from
94fe9e8 to
361bc62
Compare
ShahabT
approved these changes
Jun 25, 2025
Sushisource
approved these changes
Jun 25, 2025
stephanos
force-pushed
the
worker-deployment-stats
branch
from
361bc62 to
94bd8a9
Compare
Co-authored-by: Spencer Judge <sjudge@hey.com>
stephanos
added a commit
that referenced
this pull request
Mar 10, 2026
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** (1) Deprecated `task_queue_infos` in `deployment.WorkerDeploymentVersionInfo`. (2) Added `version_task_queues` to `DescribeWorkerDeploymentVersionResponse`. <!-- Tell your future self why have you made these changes --> **Why?** We want to report task queue stats for each task queue that is part of a worker deployment version. The challenge is that the `taskqueue` package depends on the `deployment` package. So adding `TaskQueueStats` to `deployment.WorkerDeploymentVersionInfo` causes a cycle import error. Weighing our options, we decided to effectively _move_ the task queue-related data from within the deployment package into the response message. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Not yet; but in subsequent releases the deprecated field `task_queue_infos` will be removed. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#7959 (draft) --------- Co-authored-by: Spencer Judge <sjudge@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
(1) Deprecated
task_queue_infosindeployment.WorkerDeploymentVersionInfo.(2) Added
version_task_queuestoDescribeWorkerDeploymentVersionResponse.Why?
We want to report task queue stats for each task queue that is part of a worker deployment version.
The challenge is that the
taskqueuepackage depends on thedeploymentpackage. So addingTaskQueueStatstodeployment.WorkerDeploymentVersionInfocauses a cycle import error.Weighing our options, we decided to effectively move the task queue-related data from within the deployment package into the response message.
Breaking changes
Not yet; but in subsequent releases the deprecated field
task_queue_infoswill be removed.Server PR
temporalio/temporal#7959 (draft)