Suppress logger warnings during start-dev shutdown #903
+30
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
approved these changes
Jan 12, 2026
Comment on lines
168
to
171
| if !t.Parent.Parent.LogLevel.ChangedFromDefault { | ||
| s.SuppressWarnings() | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe a short comment to explain why we're doing this? People might forget/not know how verbose the logs are on shutdown.
dandavison
force-pushed
the
stop-shutdown-log-noise
branch
from
5597e50 to
6bfd3ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Use
slog.LevelVarto suppress logger warnings during start-dev shutdown if the user has not set the log level.Why?
The warnings during shutdown are expected and damage UX.
Checklist
Built and ran manually. Confirmed
--log-levelwas respected. Issued ctrl-c and confirmed no shutdown warnings onserver start-devbut shutdown warnings onserver start-dev --log-level warn