Fix lifetime.Err format verb in simpleGRPCServer.Describe#228
Merged
Conversation
Use %v instead of %e for the error value. %e is Go's floating-point scientific-notation verb, which produced the placeholder "%!e(<nil>)" in log output whenever the lifetime context had not been cancelled. %v is the default verb for any value and is nil-safe for errors: it prints the result of err.Error() when non-nil and "<nil>" otherwise. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
temporal-nick
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use %v instead of %e for the error value. %e is Go's
floating-point scientific-notation verb, which produced the
placeholder "%!e()" in log output whenever the lifetime
context had not been cancelled. %v is the default verb for any
value and is nil-safe for errors: it prints the result of
err.Error() when non-nil and "" otherwise.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
What was changed
Why?
Checklist
Closes
How was this tested: