Split connection-provider metrics from mux metrics#229
Merged
Conversation
Replace MuxDialFailed / MuxDialSuccess with EstablisherError, and the listener-side use of MuxErrors with ReceiverError. The new counters name the layer they describe (the connection provider), which is distinct from the mux session metrics they were previously bundled with. classifyError's fallback label is also renamed from "unclassified error" to "unknown" for shorter and OCI/Prometheus-friendlier tag values. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hehaifengcn
commented
May 13, 2026
| metrics.EstablisherError.WithLabelValues(p.metricLabels...).Inc() | ||
| return nil, err | ||
| } | ||
| metrics.MuxDialSuccess.WithLabelValues(p.metricLabels...).Inc() |
Collaborator
Author
There was a problem hiding this comment.
this dups with MuxConnectionEstablish
temporal-nick
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
What was changed
Why?
Checklist
Closes
How was this tested: