Make MuxManagerStartDelay configurable#231
Open
hehaifengcn wants to merge 3 commits into
Open
Conversation
hehaifengcn
force-pushed
the
haifengh/fast-start
branch
from
27c3781 to
126cee7
Compare
- common/global_policy.go: drop the now-redundant doc comments on Policy and UpdateMuxManagerStartDelay; the field-level docs already cover the semantics. - config/config_test.go: merge TestDurationUnmarshalYAML_NestedStructAndOmitted into TestDurationUnmarshalYAML by always unmarshaling through a wrapper struct. Adds an "absent_field" row that the old top-level scalar form couldn't express. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
liam-lowe
reviewed
May 19, 2026
Contributor
liam-lowe
left a comment
liam-lowe
left a comment
There was a problem hiding this comment.
I think there is either a simpler or more optimal approach here - either feed through standard config route, or implement dynamic "readiness"
| // GlobalPolicy is the process-wide policy singleton. | ||
| var GlobalPolicy = &Policy{ | ||
| MuxManagerStartDelay: time.Minute, | ||
| } |
Contributor
There was a problem hiding this comment.
do we want to introduce a global policy here - I don't want to conflate our existing configuration approach
| // initial connections before serving. Accepts Go duration strings | ||
| // (e.g. "30s", "1m", or "0s" to skip the wait entirely). When the | ||
| // field is omitted, the in-process default (time.Minute) is used. | ||
| MuxManagerStartDelay *Duration `yaml:"muxManagerStartDelay,omitempty"` |
| @@ -1,3 +1,4 @@ | |||
| muxManagerStartDelay: "0s" | |||
Contributor
There was a problem hiding this comment.
will 0 lead to race conditions - otherwise why was it set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
not wait for local test.
Checklist
Closes
How was this tested: