Add tracing for standalone activity client calls#2344
Open
kritibehl wants to merge 1 commit into
Open
Conversation
Contributor
|
There is already a PR open for this #2302 |
Contributor
Author
|
Thanks for pointing that out, I missed #2302. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Implemented ExecuteActivity on tracingClientOutboundInterceptor so standalone activity client calls create a StartActivity span and write tracing context to the header.
Why?
Standalone activity client calls currently bypass the tracing client outbound interceptor because the tracing interceptor does not implement the standalone activity method. This means client-side tracing spans are not created for standalone activity execution.
Checklist
Closes Standalone Activities - tracing interceptor doesn't intercept standalone activities client calls #2286
How was this tested:
No docs updates needed.