Document worker activity rate limit timeout caveat#2367
Open
kritibehl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Updated the
WorkerActivitiesPerSecondfield comment to document that the worker-side activity rate limit is applied after activity tasks are received by the worker.Why?
If
WorkerActivitiesPerSecondis set very low, server-side timeouts may continue to elapse while activity tasks wait behind the worker-side rate limiter. This documents the caveat described in #1131.Checklist
Closes worker.Options.WorkerActivitiesPerSecond applies after poll is received #1131
How was this tested:
Documentation-only change.
Also ran:
go test ./internal -run TestNonExistent -count=1
No additional docs updates needed.