Set worker version on eager start requests#1033
Conversation
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Dispatch ${{ inputs.dispatch_id }} | ||
| run: echo "Dispatch ${{ inputs.dispatch_id }}" |
There was a problem hiding this comment.
Semgrep identified a blocking 🔴 issue in your code:
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by run-shell-injection.
You can view more details about this finding in the Semgrep AppSec Platform.
There was a problem hiding this comment.
/other this is from an upstream repo and doesn't run here
There was a problem hiding this comment.
Status updated to ignored by @Sushisource. Re-run the pipeline to make this finding non-blocking.
Reply with /open to re-open this finding
568a804 to
bae7ff3
Compare
What was changed
Add worker deployment options to eager workflow start requests
Why?
Needed so server has versioning info available to it when processing eager start requests
Checklist
Closes
How was this tested:
Unit tests
Any docs updates needed?