Add uds server address support for client#1288
Merged
Merged
Conversation
Contributor
Author
|
@Sushisource Thanks for the quick turnaround! Looks like some CI (unrelated to the change) failed with transient errors: I don't see an option to retry failed steps - not sure if it's a permission thing? Or if you're cool with skipping |
eb1972c to
3f8ae20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Replaced Channel::from_shared to Endpoint::from_shared in Connection::connect to support UDS server address.
Why?
See #1287
Checklist
Closes [Feature Request] Support Unix Domain Socket (UDS) for Temporal Server Addr #1287
How was this tested:
Ran
cargo testAny docs updates needed?
N/A