Skip to content

Add uds server address support for client#1288

Merged
Sushisource merged 1 commit into
temporalio:mainfrom
ryansun96:client-uds-support
May 21, 2026
Merged

Add uds server address support for client#1288
Sushisource merged 1 commit into
temporalio:mainfrom
ryansun96:client-uds-support

Conversation

@ryansun96
Copy link
Copy Markdown
Contributor

What was changed

Replaced Channel::from_shared to Endpoint::from_shared in Connection::connect to support UDS server address.

Why?

See #1287

Checklist

  1. Closes [Feature Request] Support Unix Domain Socket (UDS) for Temporal Server Addr #1287

  2. How was this tested:
    Ran cargo test

  3. Any docs updates needed?
    N/A

@ryansun96 ryansun96 requested a review from a team as a code owner May 21, 2026 04:37
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 21, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's easy :)

@ryansun96
Copy link
Copy Markdown
Contributor Author

@Sushisource Thanks for the quick turnaround! Looks like some CI (unrelated to the change) failed with transient errors:

thread 'tests::test_missing_rpc_call_has_expected_error_message' (324100) panicked at crates/sdk-core-c-bridge/src/tests/mod.rs:89:14:
called `Result::unwrap()` on an `Err` value: Ephemeral server start failed: Connection failed: Temp download file at /var/folders/x7/_nsk_h4s1kng41z5pgfbx7sh0000gn/T/temporal-sdk-rust-0.1.0.downloading not complete after 20 seconds. Make sure another download isn't running for too long and delete the temp file.
test tests::test_missing_rpc_call_has_expected_error_message ... FAILED
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

thread 'tests::test_all_rpc_calls_exist' (324097) panicked at crates/sdk-core-c-bridge/src/tests/mod.rs:153:14:
called `Result::unwrap()` on an `Err` value: Ephemeral server start failed: Connection failed: Temp download file at /var/folders/x7/_nsk_h4s1kng41z5pgfbx7sh0000gn/T/temporal-sdk-rust-0.1.0.downloading not complete after 20 seconds. Make sure another download isn't running for too long and delete the temp file.
test tests::test_all_rpc_calls_exist ... FAILED

I don't see an option to retry failed steps - not sure if it's a permission thing? Or if you're cool with skipping

@Sushisource Sushisource merged commit 96e0be0 into temporalio:main May 21, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Unix Domain Socket (UDS) for Temporal Server Addr

3 participants