fix(shutdown): Increase shutdown timeout#1290
Draft
jmaeagle99 wants to merge 1 commit into
Draft
Conversation
jmaeagle99
changed the title
jmaeagle99
force-pushed
the
cancel-poller-fix
branch
from
6cb6768 to
6d65179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Increase the shutdown timeout
Why?
The shutdown timeout is too short for some slower machines. Increase it to 5 seconds to give plenty of time for shutdown to finish. The short duration is causing CI failures in other repositories due to the dbg_panic. This should not affect release builds as they should only emit log messages instead of panicking.