Skip to content

[WIP] Add Standalone Callbacks#10100

Closed
chrsmith wants to merge 6 commits into
mainfrom
chrsmith/standalone-callbacks
Closed

[WIP] Add Standalone Callbacks#10100
chrsmith wants to merge 6 commits into
mainfrom
chrsmith/standalone-callbacks

Conversation

@chrsmith
Copy link
Copy Markdown
Contributor

@chrsmith chrsmith commented Apr 28, 2026

ℹ️ Rebase and cleanup of #9805. Accounting for refactorings such as #9798, as well as addressing some remaining code review feedback.

What changed?

Adds support for standalone callbacks...

Why?

Tell your future self why have you made these changes.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

Any change is risky. Identify all risks you are aware of. If none, remove this section.

@chrsmith chrsmith force-pushed the chrsmith/standalone-callbacks branch 3 times, most recently from 7330b20 to 95a8d64 Compare April 30, 2026 22:16
@chrsmith chrsmith force-pushed the chrsmith/standalone-callbacks branch from 95a8d64 to 6183bfd Compare May 1, 2026 16:16
@chrsmith chrsmith force-pushed the chrsmith/standalone-callbacks branch from 6183bfd to c0f4d6e Compare May 1, 2026 17:20
@chrsmith
Copy link
Copy Markdown
Contributor Author

chrsmith commented May 7, 2026

This was my WIP version of the code while I was addressing the PR feedback. I've since performed a pretty large refactoring to unify the CallbackExecution into having the Callback component work in both standalone and embedded cases.

Closing this out to create a branch for standalone-callbacks_ii.

@chrsmith chrsmith closed this May 7, 2026
@chrsmith chrsmith deleted the chrsmith/standalone-callbacks branch May 7, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant