Skip to content

Use worker_commands task queue kind when dispatching worker command#10219

Merged
rkannan82 merged 2 commits into
mainfrom
kannan/fix-worker-commands-tq-kind
May 11, 2026
Merged

Use worker_commands task queue kind when dispatching worker command#10219
rkannan82 merged 2 commits into
mainfrom
kannan/fix-worker-commands-tq-kind

Conversation

@rkannan82
Copy link
Copy Markdown
Contributor

@rkannan82 rkannan82 commented May 11, 2026

What

Change the DispatchNexusTask call in workerCommandsTaskDispatcher to use TASK_QUEUE_KIND_WORKER_COMMANDS instead of TASK_QUEUE_KIND_NORMAL.

Why

Worker commands queues use a dedicated partition type (WorkerCommandsPartition) with different properties than normal partitions. This new kind was introduced in #9899.

How did you test it?

Unit test: Updated e2e test and added an assertion on the dispatched request's task queue kind.

🤖 Generated with Claude Code

The workerCommandsTaskDispatcher was incorrectly using TASK_QUEUE_KIND_NORMAL
when dispatching cancel commands to the worker's control queue. This caused
matching to create a NormalPartition instead of a WorkerCommandsPartition,
which has different routing/partitioning/scaling behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82 rkannan82 marked this pull request as ready for review May 11, 2026 17:59
@rkannan82 rkannan82 requested review from a team as code owners May 11, 2026 17:59
@rkannan82 rkannan82 requested a review from ShahabT May 11, 2026 17:59
@rkannan82 rkannan82 changed the title Fix worker commands dispatch to use TASK_QUEUE_KIND_WORKER_COMMANDS Use worker_commands task queue kind when dispatching worker command May 11, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82 rkannan82 merged commit 808b69a into main May 11, 2026
47 checks passed
@rkannan82 rkannan82 deleted the kannan/fix-worker-commands-tq-kind branch May 11, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants