Add test hooks for DC replication tests#10322
Open
stephanos wants to merge 1 commit into
Open
Conversation
stephanos
force-pushed
the
stephanos/hooks-dc
branch
3 times, most recently
from
19d30ef to
726b74c
Compare
stephanos
commented
May 19, 2026
Comment on lines
+23
to
+26
| HistoryReplicationDLQWrite = newKey[func(any), namespace.ID]() | ||
| HistoryReplicationTaskInterceptor = newKey[func(any, func() error) error, namespace.ID]() | ||
| HistoryReplicationTaskAfterConvert = newKey[func(string, any, any) any, global]() | ||
| NamespaceReplicationTaskInterceptor = newKey[func(context.Context, *replicationspb.NamespaceTaskAttributes, func(context.Context, *replicationspb.NamespaceTaskAttributes) error) error, namespace.Name]() |
Contributor
Author
There was a problem hiding this comment.
These hooks allow changing the behavior in a more surgical manner than decorating the entire module.
stephanos
force-pushed
the
stephanos/hooks-dc
branch
5 times, most recently
from
deff028 to
2353183
Compare
stephanos
commented
May 19, 2026
| // able to route history replication tasks to test-specific (i.e. workflow-specific) buffers. Each test | ||
| // registers itself as it starts. Workflow ID is unique per test due to the use of TestVars. | ||
| testMapLock sync.Mutex | ||
| testsByWorkflowID map[string]*hrsuTest |
Contributor
Author
There was a problem hiding this comment.
ID enforced by linter
stephanos
force-pushed
the
stephanos/hooks-dc
branch
from
2353183 to
d0fed76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validation