Env-aware CHASM serialization#10360
Merged
Merged
Conversation
stephanos
commented
May 22, 2026
| // encodingTypeFromEnv returns an EncodingType based on the environment variable `TEMPORAL_TEST_DATA_ENCODING`. | ||
| // It defaults to "ENCODING_TYPE_PROTO3" codec if the environment variable is not set. | ||
| func EncodingTypeFromEnv() enumspb.EncodingType { | ||
| func encodingTypeFromEnv() enumspb.EncodingType { |
Contributor
Author
There was a problem hiding this comment.
drive-by change: this didn't need to be exported
stephanos
force-pushed
the
stephanos/otel-chasm-datablog
branch
13 times, most recently
from
3caafd2 to
80c8f5b
Compare
stephanos
force-pushed
the
stephanos/otel-chasm-datablog
branch
from
80c8f5b to
f57ec46
Compare
| data, err := marshalDeterministic(field.val.Interface().(proto.Message)) | ||
| if err != nil { | ||
| return serialization.NewSerializationError(enumspb.ENCODING_TYPE_PROTO3, err) | ||
| var err error |
Contributor
There was a problem hiding this comment.
nit: what is preferred, declaring var err, or using :=?
Contributor
Author
There was a problem hiding this comment.
We can't use := as var blob *commonpb.DataBlob is declared before and in Go we can't mix existing/non-existing vars in :=. To make it work, we'd have to invent another temp var.
awln-temporal
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced hard-coded proto encode calls with env-aware encoding.
Why?
Consistency. Only one path to encode.
How did you test it?