Upgrade/replace GitHub actions#10384
Open
stephanos wants to merge 31 commits into
Open
Conversation
stephanos
changed the title
stephanos
commented
May 25, 2026
| COMPOSE_FILE: ${{ inputs['compose-file'] }} | ||
| FLAGS: ${{ inputs.flags }} | ||
| run: | | ||
| docker compose -f "$COMPOSE_FILE" down $FLAGS |
Contributor
Author
There was a problem hiding this comment.
Could arguably be inlined, but I like the parity of the start/stop actions.
stephanos
commented
May 25, 2026
Comment on lines
-491
to
-493
| - uses: ScribeMD/docker-cache@0.3.7 | ||
| with: | ||
| key: docker-${{ runner.os }}${{ runner.arch }}-${{ hashFiles(env.DOCKER_COMPOSE_FILE) }} |
Contributor
Author
There was a problem hiding this comment.
part of docker-compose-start now
stephanos
changed the title
spkane31
reviewed
May 26, 2026
| description: Stop Docker Compose services. | ||
|
|
||
| inputs: | ||
| compose-file: |
Contributor
There was a problem hiding this comment.
Let's aim for consistency and make this compose_file and have snake case wherever we can control it.
| - name: Stop services | ||
| shell: bash | ||
| env: | ||
| COMPOSE_FILE: ${{ inputs['compose-file'] }} |
Contributor
There was a problem hiding this comment.
After changing the above this can be ${{ inputs.compose_file }}
| if: ${{ inputs.cache == 'true' && steps.restore-cache.outputs.cache-hit == 'true' }} | ||
| shell: bash | ||
| env: | ||
| CACHE_PATH: ${{ inputs['cache-path'] }} |
Contributor
There was a problem hiding this comment.
Also would prefer we are consistent with inputs.cache_path rather than inputs['cache-path']
| description: Wait for Docker Compose services to become healthy. | ||
|
|
||
| inputs: | ||
| compose-file: |
Contributor
There was a problem hiding this comment.
Suggested change
| compose-file: | |
| compose_file: |
Contributor
There was a problem hiding this comment.
Same changes in the other files as well, preferring snake case to kebab case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
nick-fields/retryactions/github-scripthoverkraft-tech/compose-action(had no new releases in years)ScribeMD/docker-cache(had no new releases in years)Successful run: https://github.com/temporalio/temporal/actions/runs/26410744692/job/77744901445?pr=10384#step:3:1
Why?
There was a flood of warnings.