fix: support Python 3.11 to prevent squatter install#107
Merged
brendanjryan merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
On Python 3.11, `pip install pympp` was installing version 0.0.1 (a name squatter) because requires-python >= 3.12 caused pip to skip all real versions. - Lower requires-python to >= 3.11 (datetime.UTC and X|Y unions work on 3.11) - Replace PEP 695 generic syntax (def func[R]) with TypeVar — the only 3.12-specific syntax in the codebase - Update ruff/pyright targets to py311
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Python 3.11,
pip install pymppinstalls version 0.0.1 — a PyPI name squatter — becauserequires-python >= 3.12causes pip to silently skip all real versions.Fix
requires-pythonto>= 3.11(datetime.UTCandX | Yunion syntax both work on 3.11)def func[R](...)) withTypeVar— the only 3.12-specific syntax in the codebasepy311