fix: default chain_id to 4217 (mainnet), matching mppx and mpp-rs#108
Merged
brendanjryan merged 4 commits intomainfrom Apr 1, 2026
Merged
fix: default chain_id to 4217 (mainnet), matching mppx and mpp-rs#108brendanjryan merged 4 commits intomainfrom
brendanjryan merged 4 commits intomainfrom
Conversation
When chain_id was omitted from tempo(), the challenge's methodDetails lacked a chainId field. The Rust CLI (mpp-rs) strictly requires chainId and rejects challenges without it: 'Malformed payment request: missing chainId'. Both mppx and mpp-rs default to 4217 (mainnet). This makes pympp consistent so servers work out of the box without explicitly passing chain_id.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The DEFAULT_FEE_PAYER_URL (sponsor.moderato.tempo.xyz) was a testnet-only service silently used as fallback when no fee payer was configured. With chain_id now defaulting to mainnet (4217), this would route mainnet transactions to a testnet sponsor. Align with mppx and mpp-rs: require explicit fee payer configuration (either a feePayer account on the method, or a feePayerUrl in methodDetails). Raise a clear error if neither is set.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
chain_idis omitted fromtempo(), the challenge'smethodDetailslacks achainIdfield. The Rust CLI strictly requires it and rejects with:Both mppx and mpp-rs default to
4217(mainnet). pympp defaulted toNone, making it the odd one out.Fix
chain_idtoCHAIN_ID(4217) in thetempo()factory, consistent with mppx and mpp-rschain_idchain_id=42431explicitly