Repository navigation
deps: update reth from main (2026-11-09) - #9054
Conversation
|
derek bench preset=tip20 |
👁️ Cyclops Security Review✅ Reviewed 4de96e8 (latest) · Coverage: partial · no open findings · report
|
|
cc @decofe ⚪ Benchmark complete: No Difference View job ⚪ Bench Comparison: No DifferenceRefs: 1f2b764 vs reth-auto-bump Configuration
Tempo Metrics
Builder
Builder details
Validator
Persistence
ObservabilityWarn/Error Logs
Counts by message
|
| reth-rpc-api = { git = "https://github.com/paradigmxyz/reth", rev = "adf5f076ad65812624afcb56018017611a106267" } | ||
| reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth", rev = "adf5f076ad65812624afcb56018017611a106267" } | ||
| reth-rpc-convert = { git = "https://github.com/paradigmxyz/reth", rev = "adf5f076ad65812624afcb56018017611a106267" } | ||
| reth-rpc-eth-api = { git = "https://github.com/paradigmxyz/reth", rev = "adf5f076ad65812624afcb56018017611a106267", features = ["account-ext"] } |
There was a problem hiding this comment.
Medium (exposure unconfirmed): Zone tracing RPCs fail for mid-block txs with a cached BAL
After the reth bump to adf5f07, the tracing and replay RPCs run a block tx that has a cached BAL on a fresh block executor positioned only by BAL index. On zone nodes that executor is a ZoneBlockExecutor still waiting for advanceTempo, so every tx at index 1 or later is rejected and no trace is returned.
Valid? React with 👍 / 👎.
7982372 to
314c42c
Compare
There was a problem hiding this comment.
I reviewed the latest push and found no bugs in the manifest changes. This push also moves evm2 (the EVM interpreter and JIT, patched to the DaniPopes fork) to a new revision. That can change execution behavior, and the diff here can't show whether it does, so a code owner should still look at the upstream changes.
What was reviewed:
- Cargo.toml: every paradigmxyz/reth git dependency now points to the same rev, 46731e93. Features and default-features flags are unchanged.
- evm2, evm2-macros and evm2-jit, plus the four [patch] entries, all move together from baf0d38f to 37fb326b, so no revision is left mismatched.
- Cargo.lock: only source and version changes (reth 2.10.0 to 2.10.1), plus one new rayon dependency on a reth crate. No second major version of any crate appears.
Extended reasoning...
The change touches only Cargo.toml and Cargo.lock. It bumps the reth git rev and the evm2 rev, including the evm2 [patch] entries that point at a personal fork, with no Rust source changes against the merge base. There is no direct injection, auth or data-exposure surface, but evm2 is the execution engine, so its new revision could change consensus behavior in ways the manifest diff can't show. CODEOWNERS assigns both Cargo.toml and Cargo.lock to specific maintainers. A third-party inline comment on Cargo.toml also exists, and this run can't see what it says or whether it was addressed.
|
cyclops audit note="Review every upstream reth commit included in the revision diff." |
| reth-rpc-api = { git = "https://github.com/paradigmxyz/reth", rev = "46731e939ea81a31fe468378f5344657640da36b" } | ||
| reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth", rev = "46731e939ea81a31fe468378f5344657640da36b" } | ||
| reth-rpc-convert = { git = "https://github.com/paradigmxyz/reth", rev = "46731e939ea81a31fe468378f5344657640da36b" } | ||
| reth-rpc-eth-api = { git = "https://github.com/paradigmxyz/reth", rev = "46731e939ea81a31fe468378f5344657640da36b", features = ["account-ext"] } |
There was a problem hiding this comment.
Low: Cached-BAL transaction tracing fails on Zone nodes with phase validation error
After the reth bump, tracing a transaction whose block has a cached block access list creates a fresh ZoneBlockExecutor and only sets its BAL index, without replaying earlier transactions. The executor stays in AwaitingAdvanceTempo, so tracing any ordinary transaction after the opening advanceTempo fails with a phase-validation error.
Valid? React with 👍 / 👎.
|
cyclops audit note="Review every upstream reth commit included in the revision diff." |
| reth-rpc-api = { git = "https://github.com/paradigmxyz/reth", rev = "5efe80f515c96fa34b569a22fb810b54f914cfb0" } | ||
| reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth", rev = "5efe80f515c96fa34b569a22fb810b54f914cfb0" } | ||
| reth-rpc-convert = { git = "https://github.com/paradigmxyz/reth", rev = "5efe80f515c96fa34b569a22fb810b54f914cfb0" } | ||
| reth-rpc-eth-api = { git = "https://github.com/paradigmxyz/reth", rev = "5efe80f515c96fa34b569a22fb810b54f914cfb0", features = ["account-ext"] } |
There was a problem hiding this comment.
Medium (exposure unconfirmed): Zone tracing fails on cached BAL because executor phase is never advanced
The reth bump makes cached-BAL tracing run the target through a new block executor that never executes the block's opening advanceTempo. On Zone nodes, ZoneBlockExecutor stays in AwaitingAdvanceTempo and rejects every later transaction. As a result, debug_traceTransaction and trace_* fail for every transaction after index 0 in a block whose BAL is cached.
Valid? React with 👍 / 👎.
Automated nightly update of reth dependencies from
paradigmxyz/rethmain branch.Upstream reth changes
0973a13...5efe80f🔗 Amp thread: https://ampcode.com/threads/T-01a1be48-3fc2-73b5-a136-e526759a67bc
eth_callgas, reject conflicting transaction fees, and respect namespace selection defaults (#28315, #28324, #28327).debug_intermediateRoots(#28266, #28331).Migrations
🔗 Amp thread: https://ampcode.com/threads/T-01a1be48-7ee3-72e7-ac8e-8bdd6d38b88c
0973a138to5efe80f5, keeping them aligned on the new upstream revision.evm2,evm2-macros, andevm2-jitfrombaf0d38fto37fb326b, including allDaniPopes/evm2patch overrides, to keep direct and patched dependencies aligned.GitHub Workflow