Bug Fix for USB Printing - #2
Open
levelfifty wants to merge 1 commit into
Open
Conversation
This was causing extra "ok" returns to the terminal on Octoprint and generating lots of resend requests as Octoprint was sending line out of order.
|
I was experiencing this same issue #1 - I could never print from USB without a layer-shift interrupting the print; I tried OctoPrint and Repetier - both had the same issue. Only prints directly from the SD card would complete. OctoPrint and Repetier logs would show 1000s of "incorrect line, resend" errors. I made this change #2 and can confirm it resolves the issue. I recommend integrating this into the next published firmware update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing extra "ok" returns to the terminal on Octoprint and generating lots of resend requests as Octoprint was sending line out of order. Fix for issue #1