FIX: Remove run_models bugs in DCN example notebook
#770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ywuenthought
commented
Dec 30, 2025
Author
There was a problem hiding this comment.
After fixing the mask_value issue, a new error shows up
/usr/local/lib/python3.12/dist-packages/keras/src/backend/tensorflow/trainer.py in multi_step_on_iterator(iterator)
131 if self.steps_per_execution == 1:
132 return tf.experimental.Optional.from_value(
--> 133 one_step_on_data(iterator.get_next())
134 )
135
ValueError: TensorFlowTrainer._make_function.<locals>.one_step_on_data(data) should not modify its Python input arguments. Modifying a copy is allowed. The following parameter(s) were modified: dataThis is due to the direct mutation of features in the compute_loss method of DCN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #755
Closes #758
This PR
mask_valuewithmask_tokenfeaturesdictFor reviewers:
You can manually test the fixed notebook using the following link
https://colab.research.google.com/github/ywuenthought/recommenders/blob/fix/dcn-notebook-bugs/docs/examples/dcn.ipynb