Added information about use of preprocessing layers to getting started notebook#275
Open
pritamdodeja wants to merge 3 commits intotensorflow:masterfrom
Open
Added information about use of preprocessing layers to getting started notebook#275pritamdodeja wants to merge 3 commits intotensorflow:masterfrom
pritamdodeja wants to merge 3 commits intotensorflow:masterfrom
Conversation
Added information about the usage of preprocessing layers to docs/get_started.ipynb, including caveats for which layers can be used, and which cannot, along with deserialization issues with Lambda layers.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rcrowe-google
requested review from
rcrowe-google
and removed request for
zoyahav
rcrowe-google
suggested changes
Oct 26, 2022
rcrowe-google
left a comment
rcrowe-google
left a comment
There was a problem hiding this comment.
Very sorry for the long delay on reviewing this!
docs/get_started.ipynb
Outdated
| "The *preprocessing function* is the most important concept of `tf.Transform`.\n", | ||
| "The preprocessing function is a logical description of a transformation of the\n", | ||
| "dataset. The preprocessing function accepts and returns a dictionary of tensors,\n", | ||
| "where a *tensor* means `Tensor` or `SparseTensor`. There are two kinds of\n", |
Author
There was a problem hiding this comment.
@rcrowe-google you are right. I will correct this and re-submit. Thank you for reviewing!
rcrowe-google
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of change
Getting started notebook was missing information about the possibility of using preprocessing layers, along with some caveats. Additionally, information about the serialization related issues having to do with the use of Lambda layers was also missing. I have added both in this pull request.