Allow caching subcircuits - #470
Draft
ohuettenhofer wants to merge 2 commits into
Draft
Conversation
… and fix missing generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
cached_subcircuitfunction which converts aQCircuitobject to aSubcircuitGateobject.When this is added to another circuit, it is treated like a gate (unlike a normal circuit where all the gates are appended directly to the existing gates, and there's no subcircuit). This means that it only needs to be compiled once, and should also save some memory.
This is currently a very simple implementation that only caches the Tequila Compilation, nothing backend specific, but it can already speed up circuit Compilation significantly:
The following code takes me around 10 seconds to run:
Replacing
circuit += subcircuitwithcircuit += cached_subcircuit(subcircuit)decreases this time to ~0.7 seconds, while (in theory) being functionally equivalent.