Kosta's awesome improvements

README.md

@@ -8,8 +8,9 @@ To work with Jenkins, you MUST install the following jenkins plugins first.
 1. [Jenkins GIT plugin](https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin)
 2. [Post build task](https://wiki.jenkins-ci.org/display/JENKINS/Post+build+task)
 3. [Mailer Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Mailer) (optional, if you want email notifications)
+4. In order to have PR verify builds, your jenkins nodes must be able to create a merge commit, meaning your jenkins users should have a ~/.gitconfig file with a user/email set.  The commits are thrown away so the value doesn't matter.
 
-If either of these are missing, things won't work.
+If any of these are missing, things won't work.
 
 # USER GUIDE
 
@@ -22,7 +23,7 @@ requests are created.
 ## INITIAL CONFIG
 
 After installing stashbot, you will need to do the following as a system
-administrator:
+administrator in stash:
 
 * Create a jenkins server configuration (one for each jenkins server you connect to) by clicking on "Stashbot Jenkins Admin" under the administration page
 * You will need to give stashbot a username/password to access jenkins which has permission to create jobs
@@ -169,6 +170,8 @@ Not every released version will necessarily be put on the Atlassian Marketplace,
 
 ## KNOWN BUGS
 
+* Calls to user(null) in RepositoryCloneLinksRequest.Builder() may be broken in Stash 3.11+
+    * Removed them for SSH but haven't tested if they need to be removed for HTTP URLs also yet...
 * JenkinsManager.updateAllJobs() and createMissingJobs() are untested.
 
 ## PLANNED FEATURES

bin/install-plugin-sdk-linux.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
-# Version 4.2.20
-DOWNLOAD_URL="https://marketplace.atlassian.com/download/plugins/atlassian-plugin-sdk-tgz/version/42230"
+# Version 5.0.13
+DOWNLOAD_URL="https://marketplace.atlassian.com/download/plugins/atlassian-plugin-sdk-tgz/version/42260"
 # To find new URLs, see: https://marketplace.atlassian.com/plugins/atlassian-plugin-sdk-tgz/versions
 
 INSTALL_BIN=`pwd`/.sdk.tar.gz

libs/com/offbytwo/jenkins/jenkins-client/0.3.0.p1/jenkins-client-0.3.0.p1.jar.md5

@@ -0,0 +1 @@
+b4e796a2623b09ade8aeb83b8687ed0c

libs/com/offbytwo/jenkins/jenkins-client/0.3.0.p1/jenkins-client-0.3.0.p1.jar.sha1

@@ -0,0 +1 @@
+f5d68197a3c910db6738dcf6ff2c48f84e6da157

libs/com/offbytwo/jenkins/jenkins-client/0.3.0.p1/jenkins-client-0.3.0.p1.pom

@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>com.offbytwo.jenkins</groupId>
+  <artifactId>jenkins-client</artifactId>
+  <version>0.3.0.p1</version>
+  <dependencies>
+    <dependency>
+      <groupId>com.fasterxml.jackson.core</groupId>
+      <artifactId>jackson-annotations</artifactId>
+      <version>2.3.4</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.fasterxml.jackson.core</groupId>
+      <artifactId>jackson-core</artifactId>
+      <version>2.3.4</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.fasterxml.jackson.core</groupId>
+      <artifactId>jackson-databind</artifactId>
+      <version>2.3.4</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>dom4j</groupId>
+      <artifactId>dom4j</artifactId>
+      <version>1.6.1</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.jvnet.hudson</groupId>
+      <artifactId>xstream</artifactId>
+      <version>1.4.7-jenkins-1</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>17.0</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>commons-lang</groupId>
+      <artifactId>commons-lang</artifactId>
+      <version>2.6</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>commons-io</groupId>
+      <artifactId>commons-io</artifactId>
+      <version>2.4</version>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.httpcomponents</groupId>
+      <artifactId>httpclient</artifactId>
+      <version>4.2.2</version>
+      <scope>runtime</scope>
+    </dependency>
+  </dependencies>
+</project>

libs/com/offbytwo/jenkins/jenkins-client/0.3.0.p1/jenkins-client-0.3.0.p1.pom.md5

@@ -0,0 +1 @@
+d016f9109a907f19105ef34f4f5b2929

libs/com/offbytwo/jenkins/jenkins-client/0.3.0.p1/jenkins-client-0.3.0.p1.pom.sha1

@@ -0,0 +1 @@
+1ec73efa618ade099c6d865595adc2917adfd8e2

libs/com/offbytwo/jenkins/jenkins-client/maven-metadata.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<metadata>
+  <groupId>com.offbytwo.jenkins</groupId>
+  <artifactId>jenkins-client</artifactId>
+  <versioning>
+    <latest>0.3.0.p1</latest>
+    <release>0.3.0.p1</release>
+    <versions>
+      <version>0.3.0.p1</version>
+    </versions>
+    <lastUpdated>20151016050210</lastUpdated>
+  </versioning>
+</metadata>

pom.xml

@@ -12,6 +12,13 @@
     <name>stashbot</name>
     <description>Stashbot is a plugin for Atlassian Stash that makes continuous integration via jenkins easy and self-servicable for end-users.</description>
     <packaging>atlassian-plugin</packaging>
+    <repositories>
+      <repository>
+        <name>stashbot-internal</name>
+        <id>stashbot-internal</id>
+        <url>file://${project.basedir}/libs</url>
+      </repository>
+    </repositories>
     <dependencyManagement>
         <dependencies>
             <dependency>
@@ -127,7 +134,7 @@
         <dependency>
             <groupId>com.offbytwo.jenkins</groupId>
             <artifactId>jenkins-client</artifactId>
-            <version>0.1.5</version>
+            <version>0.3.0.p1</version>
             <!-- excluding guava because jenkins-client uses 13 but stash needs a different version -->
             <exclusions>
                 <exclusion>
@@ -212,9 +219,9 @@
         </plugins>
     </build>
     <properties>
-        <stash.version>3.6.0</stash.version>
-        <stash.data.version>3.6.0</stash.data.version>
-        <stash.containerId>tomcat7x</stash.containerId>
+        <stash.version>3.11.4</stash.version>
+        <stash.data.version>3.11.4</stash.data.version>
+        <stash.containerId>tomcat8x</stash.containerId>
         <!--
         WARNING: manually sync this with the version in stash - variable in the
         pom has the same name but isn't imported for some reason.