fix: メールフィールド名にMySQL予約語を登録するとエラーが発生する (#4332)#1
Closed
teratai3 wants to merge 1 commit into
Closed
Conversation
Co-authored-by: tera <teratai3@users.noreply.github.com>
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
フォーク元 Issue: baserproject/basercms#4332
メールフィールドの管理画面でフィールド名にMySQLの予約語（例:
select）を登録すると、メール送信時にSQL構文エラーが発生する問題を修正。原因
MailFieldsTable::validationDefault()にMySQL予約語のバリデーションチェックが含まれていなかった。BcValidation::reserved()は既に実装済みで、bc-custom-contentのCustomFieldsTableでは適用済みだったが、MailFieldsTableには未適用だった。変更内容
plugins/bc-mail/src/Model/Table/MailFieldsTable.phpvalidationDefault()にBcValidationプロバイダー（bc）を登録field_nameフィールドにreservedバリデーションルールを追加plugins/bc-mail/tests/TestCase/Model/Table/MailFieldsTableTest.phpselect,insert,updateなどの予約語、および正常なフィールド名をテスト）テスト結果
MailFieldsTableTest: 30テスト全パス（incomplete 2件は既存）BcMailテストスイート全体: 327テスト全パス参考
CustomFieldsTableの同様の実装:https://github.com/baserproject/basercms/blob/5.1.x/plugins/bc-custom-content/src/Model/Table/CustomFieldsTable.php#L73-L78