Google Dataflow operator updated tests for an upcoming fix #13478 - #1
Open
ikholopov-omni wants to merge 1 commit into
Open
ikholopov-omni wants to merge 1 commit into
ikholopov-omni wants to merge 1 commit into
Conversation
ikholopov-omni
force-pushed
the
dataflow-fix-tests
branch
from
February 11, 2021 14:43
4010589 to
9a458b1
Compare
…wJob.test_check_dataflow_job_state_wait_until_finished test
ikholopov-omni
force-pushed
the
dataflow-fix-tests
branch
from
February 11, 2021 14:44
9a458b1 to
e4cdfb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating unit tests of Dataflow operator to avoid regression for the fix in apache#13478.
Updated tests:
tests.providers.google.cloud.hooks.test_dataflow.TestDataflowJob.test_check_dataflow_job_state_wait_until_finishedtests.providers.google.cloud.hooks.test_dataflow.TestDataflowJob.test_check_dataflow_job_state_terminal_stateThank you for investigation and upcoming with original fix! We are interested in having this fix submitted ASAP, so if you find yourself in the situation where you don't have the capacity to finish this PR right now, please let me know - I can take it over by creating a separate PR to apache/airflow.
related: apache#13262
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.